cybergis / cybergis-compute-python-sdk

https://cybergis.github.io/cybergis-compute-python-sdk
Apache License 2.0
5 stars 7 forks source link

Added docstrings to JAT.py #8

Closed taylorziegler closed 2 years ago

taylorziegler commented 2 years ago

Added docstrings to JAT.py.

alexandermichels commented 2 years ago

These look good, but I have one note: you are using "yeilds" for stuff that is returning. They are slightly different. Specifically yield returns a sequence of values in an iterator (think a list). This article discusses it: https://www.geeksforgeeks.org/use-yield-keyword-instead-return-keyword-python/

So just use returns instead of yields. Thanks!

taylorziegler commented 2 years ago

I changed all of the "yields" to returns", is it okay now?

alexandermichels commented 2 years ago

Yup, looks good!