cybergreen-net / pm

Tech project management repo (issue tracker only)
2 stars 1 forks source link

dim_asn -> ASNs are not bigints #104

Open aaronkaplan opened 7 years ago

aaronkaplan commented 7 years ago
prod=> \d dim_asn
    Table "public.dim_asn"
 Column  |  Type  | Modifiers
---------+--------+-----------
 number  | bigint | not null
 title   | text   |
 country | text   |
Indexes:
    "dim_asn_pkey" PRIMARY KEY, btree (number)
Foreign-key constraints:
    "fk_country_asn" FOREIGN KEY (country) REFERENCES dim_country(id)
Referenced by:
    TABLE "fact_count" CONSTRAINT "fk_count_asn" FOREIGN KEY (asn) REFERENCES dim_asn(number)

--> change to

prod=> \d dim_asn
    Table "public.dim_asn"
 Column  |  Type  | Modifiers
---------+--------+-----------
 number  | integer | not null
 title   | text   |
 country | varchar(2)   |
Indexes:
    "dim_asn_pkey" PRIMARY KEY, btree (number)
Foreign-key constraints:
    "fk_country_asn" FOREIGN KEY (country) REFERENCES dim_country(id)
Referenced by:
    TABLE "fact_count" CONSTRAINT "fk_count_asn" FOREIGN KEY (asn) REFERENCES dim_asn(number)

ASNs are defined by https://tools.ietf.org/html/rfc6793 as 32 bit numbers. Let's stick with that definition pls.