Closed ghost closed 7 years ago
Wouldn't that break any script with dependencies, not just Geo Mashup?
Yes, some minor issues with WP User Frontend plugin, JavaScript related.
I wouldn't expect this to work. Techniques that combine scripts with respect to dependencies might allow asynchronous loading.
I've checked twice: if I remove code, maps are rendered, if I save into my FUNCTIONS.PHP Geo Maps doesn't work. Time ago I wrote you about problem deferring Javascript too. Some incompatibilities with this?
As you agreed, the snippet you posted will potentially break any scripts with dependencies. I'd say the snippet is not compatible with WordPress script loading.
Hi. Plugin is broken and maps doesn't render if I use this function:
// Make JavaScript Asynchronous in Wordpress add_filter( 'script_loader_tag', function ( $tag, $handle ) {
if( is_admin() ) { return $tag; } return str_replace( ' src', ' async src', $tag ); }, 10, 2 );