cyberjunk / meridian59-dotnet

New 3D client and tools for Meridian 59
GNU General Public License v3.0
34 stars 36 forks source link

Allow users to slightly increase client brightness. #313

Closed skittles1 closed 4 years ago

skittles1 commented 4 years ago

Adds an slider to the Options UI under the Engine tab allowing the user to alter the ambient + directional brightness. The lowest setting is the current brightness, and max is 1.8x the current brightness. On the highest setting, Ogre displays rooms more closely to how classic does (though classic tends to be too bright).

This is in response to some players complaining that Ogre graphics are much too dark. Not everyone feels this way, so a slider allowing the players to pick is a compromise.

cyberjunk commented 4 years ago

Also one other thing:

It seems you apply this only on the ambient light, not the directional light? Have you tried using like smaller value, but on both?

I just fear a bit that it will make ambient light so much brighter that there will be no more recognizable directional light any more...

If you want to keep it for ambient light only, then please change the name to "AmbientLightFactor".

skittles1 commented 4 years ago

The directional lighting is very dim normally:

That's the view with ambient turned off and looking directly where the sun is illuminating. The better option might be to apply the factor to the directional lighting also.