cyberjunky / python-garminconnect

Python 3 API wrapper for Garmin Connect to get activity statistics
MIT License
802 stars 132 forks source link

Add grouping option to progress summary and fix type annotations #212

Closed tboerstad closed 4 days ago

tboerstad commented 2 weeks ago

This PR makes the following changes:

  1. Added 'groupbyactivities' parameter to get_progress_summary_between_dates()

    • Allows control over grouping by activity type
    • Defaults to True for backwards compatibility
  2. Updated type annotations:

    • get_devices() now returns List[Dict[str, Any]]
    • get_device_alarms() returns List[Any]
    • cdate in add_hydration_data() is now explicitly Optional
  3. Minor code cleanup:

    • Reorganized imports
    • Adjusted some function signatures

Tested:

Please review and provide feedback.

cyberjunky commented 4 days ago

Thank you, nice work!