search

cyberkaida / reverse-engineering-assistant

An AI assistant for reverse engineering tasks 👩‍💻
Apache License 2.0
243 stars 20 forks source link

Rename callback should handle global symbols #30

Closed velteyn closed 6 months ago

velteyn commented 7 months ago

Hello I want to rename a function, then I right click on reva->Rename over the function name and I obtain this:

immagine

velteyn commented 7 months ago

if you need the program I can provide it

cyberkaida commented 7 months ago

Thank you for this bug report.

The issue is that the right click rename command should detect a high symbol or a global symbol. I will update the handler to detect this case and finish the rename global symbol command to allow renaming functions.

I apologise for the inconvenience, you will have a better time with the chat functions. I am currently working hard on the Ghidra plugin, so there will be bugs and unfinished features for a few more weeks.

Please continue creating bug reports, I appreciate the work and these are helpful.

cyberkaida commented 6 months ago

The global symbol rename should work now. If we don't support renaming a specific thing, we will print to the log.

If something fails to rename, please let me know!

You should be able to right click and press rename on global symbols (functions, variables) and on things in the decompilation. I do not support everything in the listing view yet, but this should cover most cases.

velteyn commented 6 months ago

This weeknd I'll give it a try , thank you