search

cyberkitsune / PSO2Proxy

A protocol proxy for PSO2
GNU Affero General Public License v3.0
46 stars 42 forks source link

GIRC Users capable of opening a message box in-game #192

Closed acffordyce973 closed 8 years ago

acffordyce973 commented 8 years ago

By prefixing an IRC message with special characters ("👉 👌" in our tests) a GIRC user is capable of opening a message box and displaying a message to users who have global chat enabled. This is an abusable bug which is capable of stopping player movement when the message box appears and should be looked into asap. IRC Message example: 👉 👌 This is a test. Images: http://i.imgur.com/UzXQtMy.jpg http://i.imgur.com/AcmBQ0R.jpg

acffordyce973 commented 8 years ago

@alama might be able to take a look.

acffordyce973 commented 8 years ago

Apparently as long as the IRC message contains the characters at any point it'll send it as a message box to in-game users.

acffordyce973 commented 8 years ago

Also seems to be limited to system chat mode only.

cyberkitsune commented 8 years ago

This is likely due to the fact that those unicode characters as bytes are control codes for the message packet. We could potentially limited the character scope to filter out any weird characters?

alama commented 8 years ago

https://github.com/alama/PSO2Proxy/commit/e2d53911036e4c90fe4b4c80a2bb1631f0672985

alama commented 8 years ago

Why close this? the issue is that a gchat system message with some "funny" unicode bytes trigger this bug, we need to check the unicode table or have some code to filter out by byte and still have 'clear" unicode string