search

cyberkov / openhab-vim

Vim syntax files for openHAB
https://www.openhab.org/
GNU General Public License v3.0
31 stars 7 forks source link

Add Xtend as syntax #2

Open ThomDietrich opened 7 years ago

ThomDietrich commented 7 years ago

Hey, your great addition is now part of openHABian: https://community.openhab.org/t/openhabian-hassle-free-rpi-image/13379 https://github.com/ThomDietrich/openhabian/commit/9c5650f0f54138dbef9a485c1c2f22931489405e Thanks!

When testing, I ran across one problem though. GitHub utilizes an app called Linguist to highlight source code. It is of course not able to highlight .rules files. The solution to this is to put a vim modeline at the end of the file: // vim: syntax=Xtend (Example) This however collides with your syntax=openhab and highlighting is disabled.

Would you be okay to add Xtend as an alternative language to your repo?

In return adding "filetype" to my files would not be a problem. I was about to propose the whole thing as a PR against the demo config package.

ThomDietrich commented 7 years ago

@cyberkov This issue is still important. The situation even got worse as the "double feature" introduced in https://github.com/openhab/openhab-distro/pull/272 doesn't work anymore, GitHub must have changed their highlighting mechanism (check the two examples above). Are you able to look into that? You are probably the only one around here with experience in vim scripting... would be a big help!

ThomDietrich commented 7 years ago

@cyberkov could you please let me know what you think? Even a "I don't care" would be better than silence...