Build workflow - run for all boards

cyberman54 / ESP32-Paxcounter

Wifi & BLE driven passenger flow metering with cheap ESP32 boards

https://cyberman54.github.io/ESP32-Paxcounter/

Other

1.69k stars 397 forks source link

Build workflow - run for all boards #906

Closed t-huyeng closed 1 year ago

t-huyeng commented 1 year ago

WIP: working on #87

board hal file is set via ENV - CI_HALFILE and set during build.py as well as in the platformio_orig.ini with -include "src/hal/${sysenv.CI_HALFILE}"
reduce workflow to run only on ubuntu (I think this is enough for us)
runnung workflow shows a few failing boards see: https://github.com/t-huyeng/ESP32-Paxcounter/actions/runs/3368728441

We need to check why the building for some boards is failing and if this has something to do with the ci.

cyberman54 commented 1 year ago

Thanks for this work. It helps a lot to keep this code running over a wide selection of boards. I peeked into the compile errors. Many (but not all) regard to improper code in LED.cpp. I already pushed a solution for this in the development branch, and will merge this to main branch, soon.

t-huyeng commented 1 year ago

Nice, I can also merge the development into the build-workflow branch to test the changes.

Thanks for this work. It helps a lot to keep this code running over a wide selection of boards. I peeked into the compile errors. Many (but not all) regard to improper code in LED.cpp. I already pushed a solution for this in the development branch, and will merge this to main branch, soon.

And you are also okay with just testing for ubuntu at the moment? I assume that the os should not have such a big influence on this project. But we can also enable the other os at a later time if we need to.

cyberman54 commented 1 year ago

Nice, I can also merge the development into the build-workflow branch to test the changes.

ok, please do so and run a test over all environments. The "rgb led" error should be fixed for all boards.

And you are also okay with just testing for ubuntu at the moment? Yes, and this saves CPU min. (and, thus, energy).

cyberman54 commented 1 year ago

I fixed the other build errors in separate commits, which i pushed to development branch.

All hal files should compile now - except the "virtual" generic.h, this is a kitchensink with all possible build options enabled. Building this hal file results in a code size which won't fit in ESP32 memory. Need a solution for this. Meanwhile we should remove this file from the CI.