search

cybernetisk / internsystem-v2

A NextJS-based website. Used for public information about Cybernetisk Selskab, and necessary tools for volunteers at the bar/café Escape.
https://cyb.no
MIT License
7 stars 9 forks source link

Better usability for url paths #53

Closed Sebbben closed 1 month ago

Sebbben commented 1 month ago

resolves #50 Renaming the pages and main folders to "(pages)" and "(main)" next will now ignore them as a part of the url structure. This effectively removes the /pages/main part of all urls All links accept the links stored in CMS are allso updated

Sebbben commented 1 month ago

Think it might be smart to merge this as fast as possible to make sure there is the least amount of merge friction.

EricSvebakk commented 1 month ago

Dang. noticed an issue after merging to the Development-branch. It seems that your pull-request was based on an outdated version of the Main-branch which did not include the code for route /board, which is a boardmember-only page. The merge will be reverted, and this will have to be updated.

yrjarv commented 1 month ago

I just noticed that uio.no's information page for Ole-Johan Dahls hus (GA06) links to the home page in the old structure. First of all, EA should probably be informed so they can change the link on the webpage. But of course, uio.no probably isn't the only site linking to the old home page. So perhaps there should be a manual redirect in place from cyb.no/pages/main/home to cyb.no/home?

EricSvebakk commented 1 month ago

The pull-request has been accepted into main. The missing route was experimental and not necessary to include for the operation of the website. This will be handled more carefully next time.

Regaring the url on uio's page, the url seems to still work after the changes have been made to main. Worst-case, if the link stops working for some reason, then the link-text also includes the correct url: cyb.no.