cyberos / cyber-dock

Application Dock
GNU General Public License v3.0
1 stars 0 forks source link

Not all application windows are matched properly to desktop files #20

Open probonopd opened 3 years ago

probonopd commented 3 years ago

Firefox (when installed on FreeBSD by pkg) cannot be launched when pinned to the Dock because the Dock cannot figure out the corresponding .desktop file.

If you add StartupWMClass=Navigator to /usr/local/share/applications/firefox.desktop manually then you should be able to pin Firefox, but it also does not work as-is for many other applications.

Reference: https://github.com/helloSystem/ISO/issues/114#issuecomment-796920251

itsvic-dev commented 3 years ago

I can see why this would be an issue on FreeBSD/helloSystem, however I'm not able to reproduce this issue under Arch Linux/CyberOS. I can pin it to the dock just fine, and I can start it from the dock.

Seems like the Firefox desktop file, at least on Arch Linux, has StartupWMClass=firefox: https://github.com/archlinux/svntogit-packages/blob/packages/firefox/trunk/firefox.desktop#L122

Can you check if Firefox's .desktop file has StartupWMClass=firefox by default on FreeBSD? @probonopd

probonopd commented 3 years ago

It does not have that key.

itsvic-dev commented 3 years ago

Hmm. I have no idea how to help with this. Maybe you or @rekols could, you do have write access.

probonopd commented 3 years ago

Should it be StartupWMClass=Navigator (works for me) or StartupWMClass=firefox?

itsvic-dev commented 3 years ago

I have no idea, but I'm pretty sure you can repackage Firefox in helloSystem with the necessary changes. StartupWMClass=firefox works for me, but the safest bet for you would be to choose one that works the best.