Question: plan for release

zdtsw commented 1 year ago

Hello: Is there any plan to have official release published in this git repo, say, user can download pre-built jar file (i.e library/dist/webpki.org-libext-*.jar) instead of doing local compilation?

I see .github/workflows already implemented uploading artifacts, maybe it is not too complicated to publish it?

Thanks!

zdtsw commented 1 year ago

Seems it only works with jdk17+

tellison commented 1 year ago

@cyberphone Anders, it is good to see openkeystore being actively developed, and thanks for your work on this. To make use of it the team need to be able to identify a "stable version" point in time they can use.

The GitHub process for a release is quite simple, and described here. It can be a simple as tagging the source at a good point. Happy to help go through a few releases together if you wish.

cyberphone commented 1 year ago

@zdtsw You are in Sweden, my country of origin! Anyway, if you look at the source you will find that it uses conditional compilation so effectively there are three targets: JDK8 + BC, JDK17+, and Android.

If I would do a release I would probably split the thing into different pieces. There is a (in my opinion pretty neat...😀) CBOR implementation that would benefit from separation.

zdtsw commented 1 year ago

@zdtsw You are in Sweden, my country of origin! Anyway, if you look at the source you will find that it uses conditional compilation so effectively there are three targets: JDK8 + BC, JDK17+, and Android.

If I would do a release I would probably split the thing into different pieces. There is a (in my opinion pretty neat...grinning) CBOR implementation that would benefit from separation.

Tja @cyberphone !

Sorry, I did not make it clear in my previous comments. We are trying to build from source but some of the build machines set JAVA_HOME to jdk8 or jdk11, and the rest are jdk17+. From build.xml I could not find other targets than [build, android-json, tomcat, testcbor, _test, testkeygen2, _preprocess, android-cbor, android-saturn, _jdktest, testkeyalgs, testsks, _clean_android, help, _java2html, testjson, _setdoc_dir, , doc] Unless I missed out something?

The error I got with jdk11 is

build:

_jdktest:
     [echo] 
     [echo]  ***************************************************************
     [echo]     WARNING - This package has only been tested with Java 17!
     [echo]  ***************************************************************
     [echo] 
   [delete] Deleting directory /tmp/openkeystore/library/.tmp

_preprocess:
    [mkdir] Created dir: /tmp/openkeystore/library/.tmp
     [copy] Copying 22 files to /tmp/openkeystore/library/.tmp
    [javac] Compiling 347 source files to /tmp/openkeystore/library/.tmp
    [javac] /tmp/openkeystore/library/src/org/webpki/crypto/OkpSupport.java:28: error: cannot find symbol
    [javac] import java.security.interfaces.EdECKey;
    [javac]                                ^
    [javac]   symbol:   class EdECKey
    [javac]   location: package java.security.interfaces
    [javac] /tmp/openkeystore/library/src/org/webpki/crypto/OkpSupport.java:134: error: cannot find symbol
    [javac]         if (key instanceof EdECKey) {
    [javac]                            ^
    [javac]   symbol:   class EdECKey
    [javac]   location: class OkpSupport
    [javac] /tmp/openkeystore/library/src/org/webpki/crypto/OkpSupport.java:136: error: cannot find symbol
    [javac]                     ((EdECKey)key).getParams().getName(),
    [javac]                       ^
    [javac]   symbol:   class EdECKey
    [javac]   location: class OkpSupport
    [javac] 3 errors

BUILD FAILED
/tmp/openkeystore/library/build.xml:124: Compile failed; see the compiler error output for details.

cyberphone / openkeystore

Question: plan for release #4