cyberrumor / ammo

Almost Manual Mod Organizer - Linux MO for Bethesda Games
GNU General Public License v2.0
33 stars 6 forks source link

Crash when configuring some FOMODs #10

Closed Nucleartaxi closed 1 year ago

Nucleartaxi commented 1 year ago

I'm getting a crash when configuring some FOMOD installers, including ruins clutter improved and underground. It crashes immediately upon running configure #.

  File "/home/test/Documents/repos/source/ammo/ammo/./ammo.py", line 76, in <module>
    sys.exit(ui.repl())
  File "/home/test/Documents/repos/source/ammo/ammo/ui.py", line 376, in repl
    if not (ret := command["func"](*args)):
  File "/home/test/Documents/repos/source/ammo/ammo/ui.py", line 105, in configure
    steps = self.controller._fomod_install_steps(fomod_installer_root_node)
  File "/home/test/Documents/repos/source/ammo/ammo/controller.py", line 378, in _fomod_install_steps
    plug_dict["description"] = plugin.find("description").text.strip()
AttributeError: 'NoneType' object has no attribute 'strip'
cyberrumor commented 1 year ago

I wasn't able to reproduce but I pushed what I think should fix your issue. Can you try pulling the latest update and retest?

Nucleartaxi commented 1 year ago

I pulled the latest update, but it still crashes when attempting to configure the underground textures mod, same error. I deleted and reinstalled the mod as well before testing.

cyberrumor commented 1 year ago

Dang, alright. Let me get to a point where I can reproduce this then I'll get it fixed. Is this the mod that's crashing for you? https://www.nexusmods.com/skyrimspecialedition/mods/14365

Nucleartaxi commented 1 year ago

Yeah

cyberrumor commented 1 year ago

I was able to reproduce with that mod and pushed a fix up. Let me know if that works for you!

cyberrumor commented 1 year ago

Closing for lack of activity, as I'm pretty sure this is resolved now. Please feel free to open another issue if you still experience this, or if you find any other bugs. Thanks for reporting!