search

cyberrumor / ammo

Almost Manual Mod Organizer - Linux MO for Bethesda Games
GNU General Public License v2.0
25 stars 6 forks source link

Crash on Self-Terminating Description Tags #38

Closed Kajmany closed 7 months ago

Kajmany commented 7 months ago

This seems like a silly thing to do, but a mod I was trying to install did it. A FallUI component at https://www.nexusmods.com/fallout4/mods/60580 has the attached FOMOD. Starting at line 111 there's a few of these <description /> tags. This slips past the description-scraping logic because there is a description tag, but there isn't text.

Zipped because Github doesn't trust XML (should anyone?) ModuleConfig.zip

I think I have a simple fix I hope to PR shortly.

cyberrumor commented 7 months ago

Crap, didn't mean to close this lol. I'm going to keep this ticket open to remind myself to write a test for _get_steps(). We'll want to concoct a ModuleConfig.xml that has self terminating elements on all optional pieces of data rather than just for description (assuming there's more optional data). Anyway, nice fix. Thanks for the PR!