cyberrumor / ammo

Almost Manual Mod Organizer - Linux MO for Bethesda Games
GNU General Public License v2.0
32 stars 6 forks source link

confirm on delete #67

Closed duran55 closed 4 days ago

duran55 commented 5 days ago

It will be good if there is confirmation prompt before removing a mod. I accidentally removed a wrong mod by mistyping the mod index. Something like: are you sure followed by mod's name. Another workaround is to add a log file with all the actions (install, delete, etc.) performed, where someone can check what is removed last and to reinstall it manually.

cyberrumor commented 5 days ago

I've played around with making delete require confirmation, and it was exceedingly annoying in practice. I ended up drawing the line at only being able to delete visible components by <index> or <all> instead of requiring confirmation, and all was additionally restricted to only working on deactivated mods.

I share the experience that an accidental delete <index> leaves me wondering what I just removed. I think the log file is the best solution here.

I'll go ahead an expand the scope of this issue to log all actions. Don't really want to clutter the interface, so I'll probably slap a log in ~/.local/share/ammo/<game>/ammo.log.

duran55 commented 5 days ago

I agree, logging to file is better than cluttering the interface. Another idea in addition to the log file: Once delete command is executed print on screen what has been deleted. That way user can verify mod name is correct.

cyberrumor commented 4 days ago

There is a new log command which shows the contents of ~/.local/share/ammo/<game>/ammo.log. The following events appear as info level logs in that file:

- init
- deleting components
- moving components
- committing changes to disk
- renaming components
duran55 commented 4 days ago

Thanks.