cybersecrs / ripli

Ripli Downloader for HACKTOBERFEST-2020 - Starting on October 3th, 2020
https://www.github.com/cybersec/ripli
MIT License
1 stars 1 forks source link

Add superclass #10

Closed cybersecrs closed 4 years ago

cybersecrs commented 4 years ago

@ml-dalos , I got error with frozen_string, so I pushed back old branch, with one more site, which use same functions as proxyscrape. If you want check it, if not I will do it based on your previous pull request.

edit: I think it's better way to scrap everything, then if needed export proxies with regexp, unless website is like proxyscrape, to get all list at once. That way ripli would work if website change some html/css (tell me if I'am wrong). We should test which way is faster, because with more sites added it will be more important.

cybersecrs commented 4 years ago

I made some mistakes while resolving conflict between branches, but I fixed it and it's merged. I still get error with optimist:

uninitialized constant Optimist (NameError)
ml-dalos commented 4 years ago

Are you sure that you have installed gem 'optimist'?

cybersecrs commented 4 years ago

Yea afinus work

sre, 7. okt 2020. 06.45 Alexey Lebedev notifications@github.com је написао/ла:

Are you sure that you have installed gem 'optimist'?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cybersecrs/ripli/issues/10#issuecomment-704688337, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARERWS3KFFYHLUCTOFUFAO3SJPW5PANCNFSM4SEMFUBA .

cybersecrs commented 4 years ago

Where do you run it, what OS? But this code has nothing to do with OS

ml-dalos commented 4 years ago

During the merge "require 'optimitst'" was deleted from bin/ripli.rb https://github.com/cybersecrs/ripli/commit/c12387b9513fef6716fb708c70532dadc60efdaa#diff-e961354f95721027f5da36a369d5249d

cybersecrs commented 4 years ago

Dam... never again github on android... never. Thanks again, I will add topics in next minutes. I closed issuse twice by accident, merged wrong branch, and now removed optimist.

sre, 7. okt 2020. 07.29 Alexey Lebedev notifications@github.com је написао/ла:

During the merge "require 'optimitst'" was deleted from bin/ripli.rb c12387b#diff-e961354f95721027f5da36a369d5249d https://github.com/cybersecrs/ripli/commit/c12387b9513fef6716fb708c70532dadc60efdaa#diff-e961354f95721027f5da36a369d5249d

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/cybersecrs/ripli/issues/10#issuecomment-704701556, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARERWS25TW3W4OLEWAVPRYLSJP4CJANCNFSM4SEMFUBA .

cybersecrs commented 4 years ago

Yea, I removed 'require' by mistake, now it work but do not recognize arguments, each time full list is downloaded.

ml-dalos commented 4 years ago

You must specify argument -t (--type) 'ruby bin/ripli.rb --type socks4' if argument not specified used full list %w[https socks4 socks5] Argument and optimist added for simplify future adding params, e.g by adding some param you can add ability to exclude scrapers, or start only specified scrapers, or set max response timeout for proxies and it's more convenient than try to parse ARGV

cybersecrs commented 4 years ago

It is more convenient, indeed. Works fine, I prepared tor with -t, will chage to --tor.

cybersecrs commented 4 years ago

It's not faster, but much better code and easier to extend.