Fix link behaviour regarding tracked urls

cybersecuritybase / cybersecuritybase.github.io

Cyber Security Base with F-Secure

52 stars 26 forks source link

Fix link behaviour regarding tracked urls #5

Closed kimmoal closed 8 years ago

kimmoal commented 8 years ago

trackOutbound function uses document.location to change the page location, which breaks target="_blank" behaviour of opening links in tabs/windows. Also breaks Ctrl+Click and Ctrl+Cmd+Click.

To me this is very annoying as it breaks a very basic browser function and is comparable to breaking the back button!

kimmoal commented 8 years ago

I also find it odd to have cookie-consent banners visible but no mention of the extensive use of Google Analytics on the study material. The former is apparently done in response to EU law and latter is just common courtesy, but it would be nice to have something written down somewhere in similar fashion as with the surveys.