search

cybersemics / em

A beautiful, minimalistic note-taking app for personal sensemaking.
Other
261 stars 88 forks source link

Gesture diagram: Avoid overlap when crossing previous path #2057

Open raineorshine opened 2 weeks ago

raineorshine commented 2 weeks ago

Steps to Reproduce

  1. Click the Help link in the footer.
  2. Click Gesture Library.
  3. Scroll down to the Table View icon at the bottom.

Current Behavior

In the gesture diagram for the toggleTableView command, the last segment exactly touches the start point. This obscures the start point and makes the diagram less clear.

image

Expected Behavior

The last segment (with the arrow head) should stop just short of the starting point so that it is not overlapping.

This should apply if any segment would be overlapped, not just the starting point. For example, in →↓→↑← the last segment meets the start of the second segment. There is no command associated with this gesture, so I recommend changing the gesture of one of the existing commands to →↓→↑← for testing purposes.

Testing

The snapshot test already includes →↓→↑← so all you have to do is update the snapshot once it's fixed.