cybersemics / em

A beautiful, minimalistic note-taking app for personal sensemaking.
Other
282 stars 107 forks source link

Handle URL ellipsizing using CSS #2079

Closed finkef closed 2 months ago

finkef commented 3 months ago

NOTE: This PR depends on ~#2077~ #2081.

Fixes #1712, #2039, #2040, #2041, #2052, #2053, #2084, #2085.

This PR attempts fixing problems related to ellipsizing and placing of the url icon. It does so by:

Added snapshot tests that cover the cases:

Snapshot

Since this PR positions icons always immediately after the last character, it makes #2052 no longer applicable.

finkef commented 3 months ago

Can confirm that this PR also resolves #2084 and #2085.

finkef commented 3 months ago

Behavior on mobile when approaching screen edge: Screenshot 2024-07-03 at 17 30 15

finkef commented 3 months ago

@raineorshine I've rebased on the linewrap-fabian branch, resolved all outstanding comments and went through all affected issues. As we're standing right now, this PR fixes all of https://github.com/cybersemics/em/issues/1712, https://github.com/cybersemics/em/issues/2039, https://github.com/cybersemics/em/issues/2040, https://github.com/cybersemics/em/issues/2041, https://github.com/cybersemics/em/issues/2052, https://github.com/cybersemics/em/issues/2053, https://github.com/cybersemics/em/issues/2084, https://github.com/cybersemics/em/issues/2085.

The also related issue #986 remains unresolved, but will tackle that in a separate PR once we have this merged.