cybersemics / em

A beautiful, minimalistic note-taking app for personal sensemaking.
Other
282 stars 107 forks source link

Fix table heights incorrect on initial render #2086

Closed baproactive closed 3 months ago

baproactive commented 3 months ago

1889

Root Cause: Unlike other Thoughts table thoughts are rendered within a fixed width container. And to expand click area we have style max-width: calc(100% - 1em) Due to this 1em the table cell rendered in 2 lines, and later the width is updated along with other cols. But since the initial render was 2 lines it gets assigned with multiline classname which gives additional padding. <- shows extra space After user selects item or any other render action the multiline class name gets removed causing the cell back to normal height

Solution: assign max-width 100% instead of calc(100% - 1em) on table col specific cells

raineorshine commented 3 months ago

Thanks, looks good.

Can you rebase on the updated linewrap-joseph branch? It was rebased recently with changes from main.

baproactive commented 3 months ago

It's rebased now.