search

cybersemics / em

A beautiful, minimalistic note-taking app for personal sensemaking.
Other
282 stars 107 forks source link

Lottie icons 2408 (Milestone 1) #2429

Open ohrytskov opened 6 days ago

ohrytskov commented 6 days ago

2408

Replace Toolbar SVGs with New Static Icons (Milestone 1)

raineorshine commented 6 days ago

Note that the puppeteer snapshot tests are expected to fail because the toolbar appearance is changing. You can regenerate all the snapshots at the end by running yarn test:puppeteer -u.

trevinhofmann commented 2 days ago

Hi, @ohrytskov. I see you've added commits since my last review. When the PR is ready again for review, please just assign it back to me and/or let me know in the comments. Thank you!

ohrytskov commented 1 day ago

Hi @trevinhofmann, thank you for your initial feedback. I've made the updates to the PR. Could you please take another look?

raineorshine commented 1 day ago

@ohrytskov Could you update the puppeteer snapshot tests, too?

ohrytskov commented 21 hours ago

@raineorshine Thanks for the reminder! I ran yarn test:puppeteer -u, and the snapshots are all updated now.