Closed destrex271 closed 2 months ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
internal/log/log_broker_hook.go | 6 | 59.3% | ||
<!-- | Total: | 6 | --> |
Totals | |
---|---|
Change from base Build 10613049886: | -0.1% |
Covered Lines: | 1380 |
Relevant Lines: | 4863 |
No, we will keep it Receiver
. I don't see any point in renaming things. It is the same object handling all functions, at the moment UpdateMeasurements
and SyncMetrics
. If RPC sink has two different objects dealing with it, it's the choice of the author. pgwatch considers RPC sink as a single interface supporting all (at the moment 2) methods.
No, we will keep it
Receiver
. I don't see any point in renaming things. It is the same object handling all functions, at the momentUpdateMeasurements
andSyncMetrics
. If RPC sink has two different objects dealing with it, it's the choice of the author. pgwatch considers RPC sink as a single interface supporting all (at the moment 2) methods.
Ok! I'll make the required changes in receivers repo
References the current upstream version of pgwatch3_rpc_receivers where we have separated both the receiver and the sync metric handler.
A new type called Handler now handles the Sync Metric calls in the receivers: https://github.com/destrex271/pgwatch3_rpc_server/blob/1cb1f44d237ce5817831194c9285c20397277fc2/cmd/csv_receiver/main.go#L32