cybertec-postgresql / poc-plpgsql-analyzer

Proof of concept for tooling to migrate PL/SQL code to PL/pgSQL written in Rust
MIT License
7 stars 0 forks source link

Enforce stricter lint / clippy warnings #90

Closed justahero closed 1 year ago

justahero commented 1 year ago

The current command of clippy on CI is cargo clippy --no-deps does not warn about all possible lints.

Running

cargo clippy --all-targets -- -D warnings

will find a few locations where the code could be improved, e.g. in test code.

The project stepped out of being a prototype to be a more feature-rich library a while ago, therefore I suggest to deny lint warnings in the code. Thankfully most of the code is already in good shape & the number of adjustments are minimal.

Adding the following lint level on top of the lib.rs file

#![deny(warnings)]

should work with the current code. At a later point it might make sense to add #![warn(missing_docs)] as well.