search

cybertec-postgresql / vip-manager

Manages a virtual IP based on state kept in etcd or Consul
BSD 2-Clause "Simplified" License
207 stars 41 forks source link

[*] update the `version` variable default value to match the current release v2.4.0 #221

Closed XiuhuaRuan closed 5 months ago

XiuhuaRuan commented 5 months ago

The version number remains 2.0.0 while the the release number has upgraded to v2.4.0. We suggest to update the version number along with the release number to avoid version confusion.

pashagolub commented 5 months ago

Hello.

This variable is automatically set during the release workflow.

But thanks anyway.

XiuhuaRuan commented 5 months ago

@pashagolub It's my pleasure to make a little contribution to the community. Could you please double check if the release workflow is working normally and this variable is automatically set? Seems this variable keeps 2.0.0 in recent several releases.

pashagolub commented 5 months ago

How did you get the binary? Did you download it from GitHub?

XiuhuaRuan commented 5 months ago

Oh，I got it. The binary directly downloaded from GitHub has the correct version number. I built the binary from source so got the legacy version number. Anyway, we should have the updated version number in source code, right?

pashagolub commented 5 months ago

Yeah, I already merged the PR. Thanks for pointing this out!