Multiverse inventories shared the inventory (should it?)

[OriginalMadman]

I created an instance, and pass through the gate. But I keep the inventory, although the instance is a new world - and the parent world is NOT part of the same group.

I'm coming from a world in group "survival", the parent world is not in a group - and the instance is not in anything either. The parent world has separate inventory, but not the instance.

I realize this might have been intentional (in which case I will do something differently with an intermediate world).

Again, thanks - I'm sure this will be absolutely great for the server ;)

[cybertiger]

Instances should honour Multiverse-Inventories configuration for the parent world if it is present (it should also honour the gamemode setting from Multiverse-Core).

More specifically when an instance world is created, Instances reconfigures it to share everything with the world it was created from via Multiverse-Inventories API.

Please post your server log at startup where Instances loads for example:

03:06:13 [INFO] [Instances] Enabling Instances v1.5 03:06:13 [INFO] [Instances] Loading configuration 03:06:13 [INFO] [Instances] Registering event handlers 03:06:13 [INFO] [Instances] Found Multiverse-Core, attempting to create banking interface. 03:06:13 [INFO] [Instances] Muliverse-Core banking interface loaded, using: Simple Item Economy 03:06:13 [INFO] [Instances] Found PermissionsEx, attempting to create permission interface. 03:06:13 [INFO] [Instances] Enabling support for Multiverse-Inventories 03:06:13 [INFO] [Instances] Creating world manager interface for Multiverse-Core 03:06:13 [INFO] [Instances] Creating CuboidSelection interface for WorldEdit. 03:06:13 [INFO] [Instances] Registering packet handler for no-op command block editing

[cybertiger]

Might be fixed in 1.6, if it is, please let me know and I'll close this issue.

Cannot replicate in my testing environment.

[OriginalMadman]

It was still there after restart this morning. This is a section of the relevant boot log. Seems like it kinda croaks on the money too. I use Fe for economy - but that error shouldn't carry over now should it?

2013-03-12 08:06:12 [INFO] [Multiverse-Portals] Enabling Multiverse-Portals v2.5-b678 2013-03-12 08:06:12 [INFO] [Multiverse-Portals] - Version 2.5-b678 Enabled - By Rigby and fernferret 2013-03-12 08:06:16 [INFO] The update-Check only work every 24 hours, the last check was 13 hours ago. 2013-03-12 08:06:32 [INFO] [MVPLogging] 94 - Portals(s) loaded 2013-03-12 08:06:32 [INFO] [Dynmap-GriefPrevention] Enabling Dynmap-GriefPrevention v0.40 2013-03-12 08:06:32 [INFO] [Dynmap-GriefPrevention] initializing 2013-03-12 08:06:32 [INFO] [Dynmap-GriefPrevention] version 0.40 is activated 2013-03-12 08:06:32 [INFO] [HomeSpawnPlus] Enabling HomeSpawnPlus v1.7.4 2013-03-12 08:06:32 [INFO] [HomeSpawnPlus] Loaded 137 locale strings (1 overrides) 2013-03-12 08:06:32 [INFO] [HomeSpawnPlus] using VAULT:PermissionsEx for permissions 2013-03-12 08:06:32 [INFO] [HomeSpawnPlus] Vault interface found and will be used for economy-related functions 2013-03-12 08:06:32 [INFO] [HomeSpawnPlus] version 1.7.4, build 695 is enabled 2013-03-12 08:06:34 [INFO] [Multiverse-Adventure] Enabling Multiverse-Adventure v2.5-b657 2013-03-12 08:06:34 [INFO] [Multiverse-Adventure] Multiverse-Portals was found. 2013-03-12 08:06:34 [INFO] [Multiverse-Adventure 2.5-b657] Enabled - By main() 2013-03-12 08:06:35 [INFO] [Multiverse-Inventories] Enabling Multiverse-Inventories v2.5-b340 2013-03-12 08:06:35 [INFO] [Multiverse-Inventories 2.5-b340] enabled. 2013-03-12 08:06:35 [INFO] [Instances] Enabling Instances v1.5 2013-03-12 08:06:35 [INFO] [Instances] Loading configuration 2013-03-12 08:06:35 [INFO] [Instances] Registering event handlers 2013-03-12 08:06:35 [INFO] [Instances] Found Multiverse-Core, attempting to create banking interface. 2013-03-12 08:06:35 [WARNING] [Instances] Error creating Multiverse-Core banking interface java.lang.NoSuchMethodError: com.onarandombox.MultiverseCore.MultiverseCore.getBank()Lcom/fernferret/allpay/multiverse/GenericBank; at org.cyberiantiger.minecraft.instances.unsafe.bank.MultiverseCoreBank.(MultiverseCoreBank.java:32) at org.cyberiantiger.minecraft.instances.unsafe.bank.BankFactory.createBank(BankFactory.java:26) at org.cyberiantiger.minecraft.instances.Instances.onEnable(Instances.java:358) at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:217) at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:457) at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:381) at org.bukkit.craftbukkit.v1_4_R1.CraftServer.loadPlugin(CraftServer.java:282) at org.bukkit.craftbukkit.v1_4_R1.CraftServer.enablePlugins(CraftServer.java:264) at net.minecraft.server.v1_4_R1.MinecraftServer.j(MinecraftServer.java:321) at net.minecraft.server.v1_4_R1.MinecraftServer.e(MinecraftServer.java:300) at net.minecraft.server.v1_4_R1.MinecraftServer.a(MinecraftServer.java:259) at net.minecraft.server.v1_4_R1.DedicatedServer.init(DedicatedServer.java:149) at net.minecraft.server.v1_4_R1.MinecraftServer.run(MinecraftServer.java:399) at net.minecraft.server.v1_4_R1.ThreadServerApplication.run(SourceFile:849) 2013-03-12 08:06:35 [INFO] [Instances] Disabling bank support. 2013-03-12 08:06:35 [INFO] [Instances] Found PermissionsEx, attempting to create permission interface. 2013-03-12 08:06:35 [INFO] [Instances] Enabling support for Multiverse-Inventories 2013-03-12 08:06:35 [INFO] [Instances] Creating world manager interface for Multiverse-Core 2013-03-12 08:06:35 [INFO] [Instances] Creating CuboidSelection interface for WorldEdit. 2013-03-12 08:06:35 [INFO] [Instances] Registering packet handler for no-op command block editing 2013-03-12 08:06:35 [INFO] Server permissions file permissions.yml is empty, ignoring it 2013-03-12 08:06:38 [INFO] Done (57.084s)! For help, type "help" or "?" 2013-03-12 08:06:38 [INFO] Starting GS4 status listener

[cybertiger]

Multiverse-Inventories support is broken for now.

Apparently it refuses to share an inventory for a world which Multiverse-Core does not know about, which is going to make my life a whole lot more painful.

Re. the Banking issue, you're using a version of Multiverse-Core which doesn't provide the method getBank(), Instances is built against Mutliverse-Core 2.5. Thankfully Instances catches this correctly and disables the bank support.

I've no wish to write code to support the plethora of economy plugins available for Bukkit, I will switch to using Vault by default in the near future, and leave support for Multiverse-Core as option B. (Minor note, neither of which support your economy plugin Fé)

For now instanced worlds will always fall into the default group if you are using Multiverse-Inventories, so you can work around the issue to a minor extent by configuring your main worlds into a group which is not the default. Of course instances will still share inventories with all other instances, which is probably not desirable if you wish for players to start an instance with an empty inventory.

[OriginalMadman]

Another reason why it might be quite helpful with that open instance being instance0 perhaps?

Fe hooks into Vault by itself, works perfectly.

[cybertiger]

I'd rather fix it properly than add a kludge that might bite me later.

Glad to hear about Fé hooking into vault, it wasn't listed as supported in the Vault plugin documentation.

[OriginalMadman]

Hmm, I'm using dev-builds of 2.5 from march, but they have been messing with AllPay and economy integration.

[cybertiger]

Submitted a patch to MV-Inventories to fix this issue.

Please move Vault / Economy related discussion to #13

[cybertiger]

Resolved in the latest MV-Inventories

http://ci.onarandombox.com/job/Multiverse-Inventories/344/

[OriginalMadman]

Absolutely awesome job!