cybertim / blockwallet

Block Wallet
10 stars 51 forks source link

Add checksum and 0x into the Receive address #14

Closed cybertim closed 7 years ago

cybertim commented 7 years ago

Some sellers/exchanges copy/paste the address directly into their transaction system and without the 0x notation they will probably fail. Adding 0x and also the checksum will hopefully decline the amount of panic mails.

cybertim commented 7 years ago

The ‘0x’ is only a notation which indicates the address is in ‘hex’ format and not ea. decimals. So it should not matter if the 0x is supplied.

What should matter is the software processing the transaction address. In case of blockwallet it accepts addresses with or without 0x or even checksummed address will work (with uppercase letters).

You can put the address into https://etherscan.io with and without the 0x or checksummed and the result will be the same as well. But some websites/apps have broken implementations and do not check the address and even process gibberish as input, which is not within my control sadly.

Also the transactions made to the address should have an transaction hash (TxHash). You can see where the ethereum went. If there is no hash, the transaction was rejected, and no transfer has been made.

Always ask the seller for the TxHash, if they provide you with one you can check the status of your transaction on etherscan.io (its possible to scan the qr code from etherscan into blockwallet as well, so you can see the pending status in the app).

If the provider cannot give you a TxHash the transaction did not occur and the seller should give you a refund or an explanation about the issue and retry.

cybertim commented 7 years ago

Checksum and '0x' now implemented for receive in 1.1.0 (android: live, ios: now in review)