cybertron / openstack-virtual-baremetal

Tools for using OpenStack instances as baremetal deployment targets
20 stars 19 forks source link

Fix: keystone v3 parameters #34

Closed karelyatin closed 7 years ago

karelyatin commented 7 years ago

install_openstackbmc.sh fails if DOMAIN_NAME variables are sourced instead of DOMAIN_ID variables. This patch makes both ID and name parameter to work. First script tries with DOMAIN_ID parameters, if it fails try is made with DOMAIN_NAME variables. Additional rename of following two parameter is done as they were not used properly:- os__user_domain --> os_user_domain os__project_domain --> os_project_domain

cybertron commented 7 years ago

It turns out this is really hard to get right. Of the two keystone v3 clouds I've tested against, both require different env vars set and it's not at all obvious to me why. Instead of trying to fix each case as it comes up, I've written https://github.com/cybertron/openstack-virtual-baremetal/commit/ae02e88b985a406face7eda22e4b8abb1cd2c61d which basically offloads the logic to os-client-config. I believe this should address the problem you had as well. If not, please feel free to reopen.