Revert "Use more os-client-config to handle bmc auth"

cybertron / openstack-virtual-baremetal

Tools for using OpenStack instances as baremetal deployment targets

20 stars 19 forks source link

Revert "Use more os-client-config to handle bmc auth" #36

Closed lyarwood closed 7 years ago

lyarwood commented 7 years ago

This reverts commit ae02e88b985a406face7eda22e4b8abb1cd2c61d.

This is currently breaking ovb deploys on RDO Cloud :

oooq with ovb fails with "instackenv.json did not validate" https://bugs.launchpad.net/tripleo/+bug/1706585

mrunge commented 7 years ago

Reverting the mentioned patch makes deployment for me successful again. Thank you @lyarwood for debugging this.

lyarwood commented 7 years ago

@cybertron Any feedback regarding this?

steveb commented 7 years ago

Does this tripleo-quickstart-extras fix mean this revert is not necessary? https://review.openstack.org/#/c/486595/

cybertron commented 7 years ago

I would think so. I commented on the LP bug a couple days ago, but basically the problem here was that quickstart used an undocumented interface to OVB and that interface changed with this commit. Now that it's correctly using deploy.py it should be working again.

lyarwood commented 7 years ago

@cybertron Ah, apologies for missing the LP update. I'll close out this PR given we aren't going to revert the change, thanks!