search

cybertron / openstack-virtual-baremetal

Tools for using OpenStack instances as baremetal deployment targets
20 stars 19 forks source link

Fix build-nodes-json for routed networks #47

Closed hjensas closed 6 years ago

hjensas commented 6 years ago

When using routed networks, i.e multiple provision networks passing in the evironment file to build-nodes-json did'nt work. It resulted in key errors when looking up the mac address of the provision_net interface.

This change automates this by creating a provision_net_map, mapping baremetal_port id's to subnet names.

Also deprecates the --provision-net option as it is no longer needed.

cybertron commented 6 years ago

Did you mean to close this? We still need to fix it, right? Or did I screw up this PR when I rebased the routed-networks branch?

hjensas commented 6 years ago

On Tue, 2018-10-09 at 13:00 -0700, Ben Nemec wrote:

Did you mean to close this? We still need to fix it, right? Or did I screw up this PR when I rebased the routed-networks branch? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

I just suck at GitHub workflow ... I want to fix the tests in the commits togheter with the new code and ended up with a bunch of your local branch is behind the one on github etc.

I'm pretty much done, just polishing some things now and then will run a couple of tests.

Sorry for the mess ... :-/

-- Harald

cybertron commented 6 years ago

That may be my fault. I somehow messed up the rebase the first time I tried to do it and ended up with a bunch of commits out of order (not sure how it even let me reorder commits, but whatever). To fix it I had to force push to the branch which could be why you're getting messages like that.

Of course, just rebasing the branch might have done that too because the whole PR workflow is kind of dumb. I guess it's better than emailing patches though. :-)