cybex-dev / twilio_voice

Flutter Twilio Voice Plugin
https://twilio-voice-web.web.app/
MIT License
39 stars 79 forks source link

Getting Voice Notification Eventhough call is active #206

Open wmt-raj-mobile opened 9 months ago

wmt-raj-mobile commented 9 months ago

How do i restrict call notification if call is already active

cybex-dev commented 9 months ago

Hi @wmt-raj-mobile

Thanks for reaching out.

Could you explain / provide more details for "restrict call notifications", what do you have in mind?

wmt-raj-mobile commented 9 months ago

If there is ongoing call between person A and person B now if person C calls person A then person A should not receive call notification if there is ongoing call

cybex-dev commented 9 months ago

If there is ongoing call between person A and person B now if person C calls person A then person A should not receive call notification if there is ongoing call

If that could be done, how do you expect to handle subsequent calls or would you simply choose to ignore them?

wmt-raj-mobile commented 9 months ago

Yes i want to ignore that. Can you please help me with that? Also Please give exact location where i have to change the code

cybex-dev commented 9 months ago

Yes i want to ignore that. Can you please help me with that

I see - could you provide a sample use-case for this as it is extremely niche.

wmt-raj-mobile commented 9 months ago

so our user can have multiple login with same twilio number. if 2 user is using the same number and there is ongoing call with one of that user then that user should not receive call notification. Basically i don't want calll notification if there is ongoing call.

wmt-raj-mobile commented 8 months ago

Any update please help

cybex-dev commented 8 months ago

Hi @wmt-raj-mobile,

This is clearly a niche feature - moreover it can be handled on the backend/TwiML app using unique client Ids to direct calls. I'll look into adding an "ignoreIncomingCalls` feature but do not expect this any time soon.

You are more than welcome to submit a PR for this in the mean time.

wmt-raj-mobile commented 8 months ago

In IOS native code i added "" if(call != nil) {return} "" inside callInviteReceived method before reportIncomingCall method and it satisfied my requirement but don't know about android

cybex-dev commented 8 months ago

@wmt-raj-mobile thanks - though I'd need to explore in more detail the consequences of adding this, since some might not require this feature to begin with (as is my use-case).

wmt-raj-mobile commented 8 months ago

In android its merging call by itself, if call is already active and someone calls on same number