cyborg5 / IRLib2

Library for receiving, decoding, and sending infrared signals using Arduino
GNU General Public License v3.0
384 stars 138 forks source link

Compile error on Grand Central M4 #74

Closed Alkerion closed 4 years ago

Alkerion commented 5 years ago

The following error is raised when I try to compile on an Adafruit Grand Central M4


Compiling 'ServerGC_M4' for 'Adafruit Grand Central M4 (SAMD51)'

IRLibSAMD51.cpp: In function void initializeSAMD51PWM(uint16_t)

IRLibSAMD51.cpp: 32:18: error: 'PIN_ATTR_PWM' was not declared in this scope
   if ( !((attr & PIN_ATTR_PWM) == PIN_ATTR_PWM) ) {
Error compiling libraries
Build failed for project 'ServerGC_M4'
cyborg5 commented 5 years ago

There was an update to the M4 core code and I haven't had a chance to update IRLib2 in order to accommodate it. Should have it working again in a week or so. Sorry for the inconvenience.

jspolsky commented 4 years ago

quick hack to fix it:

define PWM_ATTR_PWM (1UL<<3)

cyborg5 commented 4 years ago

I was aware that the M4 code was broken. I haven't had a chance to dig into it. I will check into your fix. Many thanks.

From: Joel Spolsky [mailto:notifications@github.com] Sent: Tuesday, July 23, 2019 12:43 PM To: cyborg5/IRLib2 IRLib2@noreply.github.com Cc: Chris Young cy_borg5@cyborg5.com; Comment comment@noreply.github.com Subject: Re: [cyborg5/IRLib2] Compile error on Grand Central M4 (#74)

quick hack to fix it:

define PWM_ATTR_PWM (1UL<<3)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cyborg5/IRLib2/issues/74?email_source=notifications&email_token=AA3SBOQV5OLVNZZ5KCUSU3DQA4YHTA5CNFSM4HI5CPNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2TXEKA#issuecomment-514290216 , or mute the thread https://github.com/notifications/unsubscribe-auth/AA3SBOREQ6ADT5GNZC7P62LQA4YHTANCNFSM4HI5CPNA . https://github.com/notifications/beacon/AA3SBOT4YL4BCGSBTX7CYI3QA4YHTA5CNFSM4HI5CPNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2TXEKA.gif

cyborg5 commented 4 years ago

All support for SAMD 51 and M4 boards has been recently updated. Let me know if you have further issues. SAMD51.txt has details. The main documentation will be updated soon.