search

cybozu-go / accurate

Kubernetes controller for multi-tenancy. It propagates resources between namespaces accurately and allows tenant users to create/delete sub-namespaces.
https://cybozu-go.github.io/accurate/
Apache License 2.0
38 stars 5 forks source link

chore: deprecate v1 and v2alpha1 SubNamespace API #128

Closed erikgb closed 3 months ago

erikgb commented 4 months ago

The v2alpha1 version of the SubNamespace API has been available for a while, and I think it's time to consider deprecating the v1 version. The newer version has a much better observed state UX with conditions. We should probably make v2 (or v2beta1) available - to not "scare" our users from migrating (to an alpha version).

erikgb commented 4 months ago

I think v1 should be deplicate after releasing v2 or v2beta1.

Agree! Any more we want to adjust before v2 is finalized? I don't see anything missing from SubNamespace v2 API.

zoetrope commented 4 months ago

@erikgb I don't have anything else to add either. Everything looks good to me.

erikgb commented 4 months ago

@erikgb I don't have anything else to add either. Everything looks good to me.

Should we just skip a beta-version of the API and go directly for v2? WDYT?

zoetrope commented 4 months ago

Should we just skip a beta-version of the API and go directly for v2? WDYT?

I think it's fine to skip beta and go directly to v2.

erikgb commented 4 months ago

Should we just skip a beta-version of the API and go directly for v2? WDYT?

I think it's fine to skip beta and go directly to v2.

Thanks, I will do the work required. Marking this PR as a draft for now.

erikgb commented 3 months ago

@zoetrope After making the v2 API served, ref. https://github.com/cybozu-go/accurate/pull/132, I think this PR is ready for review and eventual merge. Marking the types as deprecated also will help us identify code we need to migrate.

erikgb commented 3 months ago

@zoetrope A gentle ping for a review of this PR. 🙏 I also have other open unreviewed PRs. 🙏 We prefer if a new release is cut as soon as possible. 🤠

zoetrope commented 3 months ago

@erikgb Sorry for the very late reply. I am planning to make a release. Can I release v1.4.0 after this PR is merged?

erikgb commented 3 months ago

@erikgb Sorry for the very late reply. I am planning to make a release. Can I release v1.4.0 after this PR is merged?

@zoetrope Great! Would it be possible to include all open PRs before we cut the release? In particular, I would like to get https://github.com/cybozu-go/accurate/pull/142 in somehow.