Closed ymmt2005 closed 1 month ago
@ymmt2005 Do you have any thoughts about the UX of this feature? Should it be configured:
@zoetrope @ymmt2005 We are facing this issue in our clusters, and I want to fix it. Do you have some input to my question above? I think the implementation complexity will increase in order from 1 to 3. I only need this configured globally, so I'll vote for 1 - at least as a start.
@erikgb Sorry, I didn't notice your question.
I agree with option 1.
What
Accurate can propagate any namespace resource between namespaces. While copying the resource, all labels and annotations except for ones that contain
kubernetes.io/
are inherited. https://github.com/cybozu-go/accurate/blob/ae009976539579320acf5765081c0590ca93819d/controllers/propagate.go#L24-L55In some cases, the copied labels or annotations can cause problems. For instance, if Argo CD is configured to track the managed resources by
argocd.argoproj.io/instance
label and the parent resource was created by Argo CD, the propagated resource would have the same label. Argo CD then tries to delete the propagated resource because the propagated resource is not found on the source Git repository.So, add a feature to exclude particular labels or annotations from propagated resources.
How
Describe how to address the issue.
Checklist