search

cybozu-go / accurate

Kubernetes controller for multi-tenancy. It propagates resources between namespaces accurately and allows tenant users to create/delete sub-namespaces.
https://cybozu-go.github.io/accurate/
Apache License 2.0
38 stars 5 forks source link

fix: add missing spec.issuerRef.group to cert-manager Certificate| #83

Closed erikgb closed 11 months ago

erikgb commented 11 months ago

We are using cert-manager/approver-policy in our clusters, and are hitting this issue: https://github.com/cert-manager/approver-policy/issues/179

This PR adds the cert-manager.io as the issuer group - which is anyway the default in cert-manager controller.

erikgb commented 11 months ago

The CI seems to fail with an unrelated error. Is it a flake?

ymmt2005 commented 11 months ago

Looks pretty much like a flake. Re-running it. https://github.com/cybozu-go/accurate/blob/5cf897ada5b936f579c3c578d2520e9e75796d26/hooks/namespace_test.go#L438

ymmt2005 commented 11 months ago

passed.