search

cybozu-go / aptutil

Go utilities for Debian APT repositories
MIT License
125 stars 29 forks source link

Avoid consuming too much memory #14

Closed ymmt2005 closed 6 years ago

ymmt2005 commented 7 years ago

https://github.com/cybozu-go/aptutil/blob/ec162e2c52fd6a07f6d95d667568f7ed2f8623fc/mirror/mirror.go#L280

go-apt-mirror keeps downloaded data in memory. This may result in excessive memory usage while downloading debs.

go-apt-cacher has a similar issue.

ymmt2005 commented 7 years ago

https://github.com/cybozu-go/aptutil/blob/ec162e2c52fd6a07f6d95d667568f7ed2f8623fc/mirror/mirror.go#L272

This "downloaded" message is also confusing. In fact, file body will be read after the message is logged.

ymmt2005 commented 6 years ago

@henrich This issue will be fixed shortly. We are fixing. Cc: @nishitaniyuki