search

cybozu-go / coil

CNI plugin for Kubernetes designed for scalability and extensibility
Apache License 2.0
164 stars 20 forks source link

AddressPool should have a finalizer #132

Closed ymmt2005 closed 3 years ago

ymmt2005 commented 3 years ago

Describe the bug

Due to a bug in kube-apiserver, although there are still AddressBlocks curved from an AddressPool, the AddressPool would be deleted even though AddressBlock has ownerReferences with blockOwnerDeletion=true.

https://github.com/kubernetes/kubernetes/issues/86509#issuecomment-601188296

So, AddressPool should have a finalizer until all of its child AddressBlocks get deleted.

Environments

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Additional context Add any other context about the problem here.

ymmt2005 commented 3 years ago

maybe fixed in k8s 1.20?