Closed masap closed 2 years ago
make test
passes on my local environment. Is there any way to re-run the failed CI ?
Thank you for your PR!
You can specify kubectl version like make setup K8S_VERSION=1.21.1
However, I understand that the Makefile still has a room for improvement. So let me handle it on #185. Is it OK with you?
You can specify kubectl version like
make setup K8S_VERSION=1.21.1
.
I know that :). But specifying K8S_VERSION
to both make setup
and make start
is redundant.
So let me handle it on #185. Is it OK with you?
No. If you have any other idea, request change to this PR or do it after this PR please.
We don't consider this a critical issue, and currently, we're a bit occupied dealing with other high-priority tasks. So allow us to close this PR now. We promise to improve this issue soon. I apologize for the inconvenience.
Previously,
kubectl
version is 1.19 even whenkube-apiserver
is 1.22.kubectl
version should be +1,0,-1 ofkube-apiserver
version. https://kubernetes.io/releases/version-skew-policy/Therefore, this patch fixes it to use the same version as
kube-apiserver
.Signed-off-by: Masashi Honma masashi.honma@gmail.com