search

cybozu-go / coil

CNI plugin for Kubernetes designed for scalability and extensibility
Apache License 2.0
165 stars 20 forks source link

useless replace usage left in go.mod #240

Closed Morty-luo closed 1 year ago

Morty-luo commented 1 year ago

It seems that module github.com/cybozu-go/coil/v2 does not depend on github.com/dgrijalva/jwt-go any more, both directly and indirectly. So, replace usage left in go.mod makes no sense. Should it be dropped?

$ go mod why -m github.com/golang-jwt/jwt/v4
# github.com/golang-jwt/jwt/v4
(main module does not need module github.com/golang-jwt/jwt/v4)

https://github.com/cybozu-go/coil/blob/main/v2/go.mod#L5

replace github.com/dgrijalva/jwt-go => github.com/golang-jwt/jwt/v4 v4.4.2
ysksuzuki commented 1 year ago

Hi @Morty-luo, thank you for reporting this issue! The said replace directive has been removed in #241