Rename the CRD's finalizer name - Githubissues

cybozu-go / coil

CNI plugin for Kubernetes designed for scalability and extensibility

Apache License 2.0

158 stars 18 forks source link

Rename the CRD's finalizer name #270

Open terassyi opened 5 months ago

terassyi commented 5 months ago

What

Rename finalizer from coil.cybozu.com to coil.cybozu.com/finalizer.

New coil's CRD can add finalizers that don't have /. In the future, CRD's finalizers also will need to have /.

ref: https://github.com/kubernetes/kubernetes/pull/119508

How

Coil adds the finalizer like following.

https://github.com/cybozu-go/coil/blob/5653f1dd911c086f41cb9ce3c5c89ec50955c4ca/v2/api/v2/addresspool_webhook.go#L28

We have to rename its name and migrate existing finalizers.

Checklist

[ ] Finish implentation of the issue
[ ] Test all functions
[ ] Have enough logs to trace activities
[ ] Notify developers of necessary actions