Closed shunki-fujita closed 3 months ago
Describe the bug There is code that tries to disable binlog. https://github.com/cybozu-go/moco/blob/a7352fa275f057ac6b1249eeeb6749d64b6504e3/pkg/mycnf/generator.go#L168
However, this variable is the filename of binlog and does not disable binlog. https://dev.mysql.com/doc/refman/8.0/en/replication-options-binary-log.html#option_mysqld_log-bin
To disable binlog, either skip-log-bin or disable-log-bin must be specified. Thus, delete() here is not working as intended.
Expected behavior Specifying skip-log-bin or disable-log-bin does not disable binlog
Describe the bug There is code that tries to disable binlog. https://github.com/cybozu-go/moco/blob/a7352fa275f057ac6b1249eeeb6749d64b6504e3/pkg/mycnf/generator.go#L168
However, this variable is the filename of binlog and does not disable binlog. https://dev.mysql.com/doc/refman/8.0/en/replication-options-binary-log.html#option_mysqld_log-bin
To disable binlog, either skip-log-bin or disable-log-bin must be specified. Thus, delete() here is not working as intended.
Expected behavior Specifying skip-log-bin or disable-log-bin does not disable binlog