search

cybre-finn / next-companion

Rogue client for nextbike
GNU General Public License v3.0
23 stars 8 forks source link

[Bugfix] Fix logout bug #31

Closed loewenzahm closed 2 years ago

loewenzahm commented 2 years ago

On a logout the login-key has not been removed from the shared preferences due to a typo ("loginkey" instead of "loginKey"). Now that the typo is fixed the login key is no longer kept stored after logouts which resolves the bug mentioned in issue #16

cybre-finn commented 2 years ago

Thanks for your pull request! I'm currently not on the android platform, but as it's a really simple change i'll just merge it. @lgehr can you validate that this works before the next release?

It's your first PR as far as I can see. Keep it going! :fire:

loewenzahm commented 2 years ago

Hey @h0chi ! This is probably the smallest possible bugfix with only one character changed. :D But I would also like to contribute more to your nice project in future if that fits for you? :)

loewenzahm commented 2 years ago

Thanks for your nice message. :)

cybre-finn commented 2 years ago

Of course, that would be great. Actually the @lgehr is the person who was recently more active on this repo as I migrated away from Android and Nextbike (no Nextbike near me). But if you have any questions, I'll try to answer them as best as I can.