cycfi / q

C++ Library for Audio Digital Signal Processing
MIT License
1.12k stars 146 forks source link

fix missing "inline" in dynamic.hpp for android ndk-build #65

Closed alperc84 closed 1 year ago

alperc84 commented 1 year ago

Fixes android ndk-build "duplicate symbol" error.

"inline" may not have been added on purpose or accidentally. I am not expert with this (c++17). But seems like fixing android ndk build while don't broke Windows build.

It should be evaluated by a specialist before commit.

Error message in ndk-build without "inline":

ld: error: duplicate symbol: cycfi::q::soft_knee_compressor::threshold(cycfi::q::decibel)
>>> defined at dynamic.hpp:192 (./include\q/fx\dynamic.hpp:192)
djowel commented 1 year ago

Missed that. Thanks!