cycjimmy / semantic-release-action

GitHub Action for Semantic Release
https://github.com/marketplace/actions/action-for-semantic-release
MIT License
550 stars 98 forks source link

feat: update node version to 20 #171

Closed enell closed 1 year ago

enell commented 1 year ago

Type of Change

Resolves

Describe Changes

Node20 is being rolled out on github runnes

MikeMcC399 commented 1 year ago

@enell

I would consider this a breaking change leading to a new major version bump, not simply a chore:.

Also the documentation would need updating, for instance: https://github.com/cycjimmy/semantic-release-action#semantic_version

enell commented 1 year ago

Yes you are correct. But is is a fix or feat?

MikeMcC399 commented 1 year ago

Hopefully @cycjimmy will get involved and assist with the PR!

Alegrowin commented 1 year ago

@enell I went a little ahead and upgraded to semantic release 21 and node 20 as a default everywhere.

https://github.com/enell/semantic-release-action/pull/1/files

cycjimmy commented 1 year ago

I've been a bit busy with my current job and will probably attempt a new upgrade version next week. The new version will be a BREAKING CHANGE. If you are trying to upgrade, you can submit using the feat keyword and add BREAKING CHANGE to the commit message footer.

MikeMcC399 commented 1 year ago

@enell

You need to have the following text included literally in your commit:

BREAKING CHANGE:

and this would be

feat:

not simply

chore!:

I'm just echoing what @cycjimmy already wrote in https://github.com/cycjimmy/semantic-release-action/pull/171#issuecomment-1690276539, in case it was not clear to you.

enell commented 1 year ago

@MikeMcC399 Just updated

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 4.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

cycjimmy commented 1 year ago

This PR has been updated to the main branch. The new version is v4. Thanks for your contributions.