cycle / annotated

Schema generation using annotated entities and mappers
MIT License
23 stars 12 forks source link

fix STI for config via php attributes #37

Closed gam6itko closed 2 years ago

gam6itko commented 2 years ago

STI not works for config via php8-attributes without doc comments.

I have similar 2 pair of classes with ORM config via Annotations and Attributes. As you see on left side on screenshot ORM creates one table for [ClassA1, ClassA2] and two tables for [ClassB1, ClassB2] image

codecov[bot] commented 2 years ago

Codecov Report

Merging #37 (d70ce15) into master (fc7e5e1) will increase coverage by 0.19%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #37      +/-   ##
============================================
+ Coverage     89.87%   90.07%   +0.19%     
+ Complexity      201      200       -1     
============================================
  Files            15       15              
  Lines           415      413       -2     
============================================
- Hits            373      372       -1     
+ Misses           42       41       -1     
Impacted Files Coverage Δ
src/Entities.php 94.80% <ø> (+1.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fc7e5e1...d70ce15. Read the comment docs.

roxblnfk commented 2 years ago

👍