search

cycle / annotated

Schema generation using annotated entities and mappers
MIT License
23 stars 12 forks source link

Remove check for docblock when trying to find parent entities (#54) #55

Closed makedo closed 1 year ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #55 (6e998d0) into 3.x (fa3263e) will increase coverage by 0.12%. The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.x      #55      +/-   ##
============================================
+ Coverage     90.74%   90.86%   +0.12%     
+ Complexity      253      252       -1     
============================================
  Files            32       32              
  Lines           648      646       -2     
============================================
- Hits            588      587       -1     
+ Misses           60       59       -1
Impacted Files Coverage Δ
src/Utils/EntityUtils.php 90.47% <ø> (+3.51%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

roxblnfk commented 2 years ago

Can you add test case?

makedo commented 2 years ago

Can you add test case?

Added test case. Not sure if the way test implemented is fine. Thank you.

roquie commented 1 year ago

After this fix I got generated extra columns from child entities in parent class (JTI usage) schema declaration. Don't merge it. Need complex test and code refactoring.

roxblnfk commented 1 year ago

@msmakouz may be related to https://github.com/cycle/annotated/pull/65

msmakouz commented 1 year ago

After this fix I got generated extra columns from child entities in parent class (JTI usage) schema declaration. Don't merge it. Need complex test and code refactoring.

Hi, this bug fixed by: #65