Closed roxblnfk closed 1 year ago
Merging #123 (5683bd3) into 2.x (d5b1be2) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## 2.x #123 +/- ##
=========================================
Coverage 94.68% 94.68%
Complexity 1667 1667
=========================================
Files 96 96
Lines 4496 4497 +1
=========================================
+ Hits 4257 4258 +1
Misses 239 239
Impacted Files | Coverage Δ | |
---|---|---|
src/Query/Traits/TokenTrait.php | 93.98% <100.00%> (+0.04%) |
:arrow_up: |
The first Scope implementation is invalid
Fix
I'm not sure about that fix because it might be related with building for bad query. After the fix I get some think like this:
Upd:
The bad query produces Cycle ORM Scope:
That query code can be replaced with this one:
But we need to research if the origin code was correct. If yes - need to fix QueryBuilder