cycle / database

Database Abstraction Layer, Schema Introspection, Schema Generation, Query Builders
MIT License
53 stars 22 forks source link

Improve psalm types for `DatabaseInterface::transaction()` #163

Closed vjik closed 4 months ago

vjik commented 4 months ago

What was changed

Add more specific type for "DatabaseInterface::transaction()".

Why?

Psalm error in app. I am waiting callback result as method result.

Checklist

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.23%. Comparing base (f9f70c8) to head (5dadc8d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.x #163 +/- ## ========================================= Coverage 95.23% 95.23% Complexity 1833 1833 ========================================= Files 130 130 Lines 5054 5054 ========================================= Hits 4813 4813 Misses 241 241 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vjik commented 4 months ago

Please fill the form in the PR description

Done

roxblnfk commented 4 months ago

Thanks