cycle / database

Database Abstraction Layer, Schema Introspection, Schema Generation, Query Builders
MIT License
53 stars 22 forks source link

fix: add parameter consideration when hashing the query part with orderBy #206

Closed msmakouz closed 4 weeks ago

msmakouz commented 1 month ago

🔍 What was changed

The orderBy method can accept a Cycle\Database\Injection\FragmentInterface. These can be instances of the Cycle\Database\Injection\Fragment and Cycle\Database\Injection\Expression classes. They may contain parameters, but these were not considered when hashing this part of the query. I added their consideration, similar to how it is done for the other parts of the query.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.33%. Comparing base (122163b) to head (375f47b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.x #206 +/- ## ============================================ + Coverage 95.21% 95.33% +0.12% - Complexity 1856 1859 +3 ============================================ Files 130 130 Lines 5136 5143 +7 ============================================ + Hits 4890 4903 +13 + Misses 246 240 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.