search

cycle / database

Database Abstraction Layer, Schema Introspection, Schema Generation, Query Builders
MIT License
54 stars 23 forks source link

Fix replacement of the question mark in Interpolator #56

Closed laxity7 closed 2 years ago

laxity7 commented 2 years ago

Fix https://github.com/cycle/database/issues/57

codecov[bot] commented 2 years ago

Codecov Report

Merging #56 (8b2b2e4) into 2.x (2496d77) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x      #56      +/-   ##
============================================
+ Coverage     92.69%   92.71%   +0.02%     
  Complexity     1520     1520              
============================================
  Files            94       94              
  Lines          3858     3858              
============================================
+ Hits           3576     3577       +1     
+ Misses          282      281       -1
Impacted Files Coverage Δ
src/Query/Interpolator.php 91.89% <100.00%> (+2.70%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2496d77...8b2b2e4. Read the comment docs.

roxblnfk commented 2 years ago

I made https://github.com/cycle/database/pull/60 to fix all issued cases. Can you check it please?

laxity7 commented 2 years ago

yes, it works correctly