search

cycle / schema-builder

Declarative schema generation for Cycle ORM
MIT License
15 stars 11 forks source link

Remove type consistency check for morphed relations #16

Closed rauanmayemir closed 4 years ago

rauanmayemir commented 4 years ago

This PR removes the type consistency check for morphed relation keys and while it will miss cases where types are obviously wrong, e.g accidental integer to varchar relation, it will however be more lenient on int to bigint which is very often an occasion with morphed relations.

Since morphs do not need foreign keys, I believe there's no need for such checks.

codecov[bot] commented 4 years ago

Codecov Report

Merging #16 into master will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
- Coverage     89.13%   89.11%   -0.03%     
+ Complexity      399      398       -1     
============================================
  Files            31       31              
  Lines          1003     1001       -2     
============================================
- Hits            894      892       -2     
  Misses          109      109
Impacted Files Coverage Δ Complexity Δ
src/Relation/Traits/MorphTrait.php 93.10% <ø> (-0.45%) 12.00 <0.00> (-1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 58769c7...9a5ebb7. Read the comment docs.